NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit920311a

committed

For 11 only, put back heap_expand_tuple to GetTupleForTrigger().

This is not necessary anymore after297d627, but extensions that havenot been recompiled after the fix will not use the new definition ofheap_getattr(). While recompiling those extensions is obviously thesuggested course, it's cheap enough to retain the expansion inGetTupleForTrigger().Per suggestion from Andrew Gierth.Discussion: 87va1x43ot.fsf@news-spur.riddles.org.uk

1 parent35afcca commit920311aCopy full SHA for 920311a

File tree

1 file changed

-1

lines changed

src/backend/commands
- trigger.c

1 file changed

-1

lines changed

`‎src/backend/commands/trigger.c`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3396,7 +3396,15 @@ ltrmark:;`
`3396`	`3396`	`LockBuffer(buffer,BUFFER_LOCK_UNLOCK);`
`3397`	`3397`	`}`
`3398`	`3398`
`3399`		`-result=heap_copytuple(&tuple);`
	`3399`	`+/*`
	`3400`	`+ * While this is not necessary anymore after 297d627e, as a defense`
	`3401`	`+ * against C code that has not recompiled for minor releases after the`
	`3402`	`+ * fix, continue to expand the tuple.`
	`3403`	`+ */`
	`3404`	`+if (HeapTupleHeaderGetNatts(tuple.t_data)<relation->rd_att->natts)`
	`3405`	`+result=heap_expand_tuple(&tuple,relation->rd_att);`
	`3406`	`+else`
	`3407`	`+result=heap_copytuple(&tuple);`
`3400`	`3408`	`ReleaseBuffer(buffer);`
`3401`	`3409`
`3402`	`3410`	`returnresult;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit920311a

File tree

1 file changed

1 file changed

`‎src/backend/commands/trigger.c`

0 commit comments