Commit91e7115

committed

Throw a more on-point error for publications depending on columns.

Same as42b0412, except that the trouble case is a publicationWHERE clause that depends on a column.Again reported by Alexander Lakhin. Back-patch to v15 wherewe added publication WHERE clauses.Discussion:https://postgr.es/m/548a47bc-87ae-b3df-c6a2-60b9966f808b@gmail.com

1 parentd45597f commit91e7115Copy full SHA for 91e7115

File tree

+16

-0

lines changed

+16

-0

lines changed

Lines changed: 16 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@`
`46`	`46`	`#include "catalog/pg_opclass.h"`
`47`	`47`	`#include "catalog/pg_policy.h"`
`48`	`48`	`#include "catalog/pg_proc.h"`
	`49`	`+#include "catalog/pg_publication_rel.h"`
`49`	`50`	`#include "catalog/pg_rewrite.h"`
`50`	`51`	`#include "catalog/pg_statistic_ext.h"`
`51`	`52`	`#include "catalog/pg_tablespace.h"`
`@@ -14227,6 +14228,21 @@ RememberAllDependentForRebuilding(AlteredTableInfo *tab, AlterTableType subtype,`
`14227`	`14228`	`RememberStatisticsForRebuilding(foundObject.objectId, tab);`
`14228`	`14229`	`break;`
`14229`	`14230`
	`14231`	`+case PublicationRelRelationId:`
	`14232`	`+`
	`14233`	`+/*`
	`14234`	`+ * Column reference in a PUBLICATION ... FOR TABLE ... WHERE`
	`14235`	`+ * clause. Same issues as above. FIXME someday.`
	`14236`	`+ */`
	`14237`	`+if (subtype == AT_AlterColumnType)`
	`14238`	`+ereport(ERROR,`
	`14239`	`+(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
	`14240`	`+ errmsg("cannot alter type of a column used by a publication WHERE clause"),`
	`14241`	`+ errdetail("%s depends on column \"%s\"",`
	`14242`	`+ getObjectDescription(&foundObject, false),`
	`14243`	`+ colName)));`
	`14244`	`+break;`
	`14245`	`+`
`14230`	`14246`	`default:`
`14231`	`14247`
`14232`	`14248`	`/*`

Comments

(0)