Commit9170da9

committed

pg_upgrade: set vacuum_defer_cleanup_age to zero

Non-zero vacuum_defer_cleanup_age values cause pg_upgrade freezing ofthe system catalogs to be incomplete, or do nothing. This will causethe upgrade to fail in confusing ways.Reported-by: Laurenz AlbeDiscussion:https://postgr.es/m/7d6f6c22ba05ce0c526e9e8b7bfa8105e7da45e6.camel@cybertec.atBackpatch-through: 9.5

1 parente2aca0d commit9170da9Copy full SHA for 9170da9

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -240,6 +240,9 @@ start_postmaster(ClusterInfo *cluster, bool report_and_exit_on_error)`
`240`	`240`	`* we only modify the new cluster, so only use it there. If there is a`
`241`	`241`	`* crash, the new cluster has to be recreated anyway. fsync=off is a big`
`242`	`242`	`* win on ext4.`
	`243`	`+ *`
	`244`	`+ * Force vacuum_defer_cleanup_age to 0 on the new cluster, so that`
	`245`	`+ * vacuumdb --freeze actually freezes the tuples.`
`243`	`246`	`*/`
`244`	`247`	`snprintf(cmd,sizeof(cmd),`
`245`	`248`	`"\"%s/pg_ctl\" -w -l \"%s\" -D \"%s\" -o \"-p %d%s%s %s%s\" start",`
`@@ -248,7 +251,7 @@ start_postmaster(ClusterInfo *cluster, bool report_and_exit_on_error)`
`248`	`251`	`BINARY_UPGRADE_SERVER_FLAG_CAT_VER) ?" -b" :`
`249`	`252`	`" -c autovacuum=off -c autovacuum_freeze_max_age=2000000000",`
`250`	`253`	`(cluster==&new_cluster) ?`
`251`		`-" -c synchronous_commit=off -c fsync=off -c full_page_writes=off" :"",`
	`254`	`+" -c synchronous_commit=off -c fsync=off -c full_page_writes=off -c vacuum_defer_cleanup_age=0" :"",`
`252`	`255`	`cluster->pgopts ?cluster->pgopts :"",socket_string);`
`253`	`256`
`254`	`257`	`/*`

Comments

(0)