Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit91572ee

Browse files
committed
Make pg_dumpall build with the right object files under MSVC.
This fixes a longstanding but up to now benign bug in the way pg_dumpallwas built. The bug was exposed by recent code adjustments. The Makefiledoes not use $(OBJS) to build pg_dumpall, so this fix removes their sourcefiles from the pg_dumpall object and adds in the one source file itconsequently needs.
1 parent9f4563f commit91572ee

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

‎src/tools/msvc/Mkvcbuild.pm

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,9 +344,17 @@ sub mkvcbuild
344344
$pgdump->AddFile('src\backend\parser\kwlookup.c');
345345

346346
my$pgdumpall = AddSimpleFrontend('pg_dump', 1);
347+
# pg_dumpall doesn't use the files in the Makefile's $(OBJS), unlike
348+
# pg_dump and pg_restore.
349+
# So remove their sources from the object, keeping the other setup that
350+
# AddSimpleFrontend() has done.
351+
my@nodumpall =grep {m/src\\bin\\pg_dump\\.*\.c$/ }
352+
keys %{$pgdumpall->{files}};
353+
delete @{$pgdumpall->{files}}{@nodumpall};
347354
$pgdumpall->{name} ='pg_dumpall';
348355
$pgdumpall->AddIncludeDir('src\backend');
349356
$pgdumpall->AddFile('src\bin\pg_dump\pg_dumpall.c');
357+
$pgdumpall->AddFile('src\bin\pg_dump\dumputils.c');
350358
$pgdumpall->AddFile('src\bin\pg_dump\keywords.c');
351359
$pgdumpall->AddFile('src\backend\parser\kwlookup.c');
352360

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp