Commit91416f4

committed

doc: Fix description of replication command CREATE_REPLICATION_SLOT

The output plugin name is a mandatory option when creating a logicalslot, but the grammar documented was not described as such. While onit, fix two comments in repl_gram.y to show that TEMPORARY is anoptional grammar choice.Author: Ayaki TachikakeDiscussion:https://postgr.es/m/OSAPR01MB2852607B2329FFA27834105AF1229@OSAPR01MB2852.jpnprd01.prod.outlook.comBackpatch-through: 15

1 parent42d203c commit91416f4Copy full SHA for 91416f4

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1987,7 +1987,7 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;"`
`1987`	`1987`	`</varlistentry>`
`1988`	`1988`
`1989`	`1989`	`<varlistentry id="protocol-replication-create-replication-slot" xreflabel="CREATE_REPLICATION_SLOT">`
`1990`		`- <term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [ <literal>TEMPORARY</literal> ] { <literal>PHYSICAL</literal> \| <literal>LOGICAL</literal> } [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ]`
	`1990`	`+ <term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [ <literal>TEMPORARY</literal> ] { <literal>PHYSICAL</literal> \| <literal>LOGICAL</literal><replaceable class="parameter">output_plugin</replaceable>} [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ]`
`1991`	`1991`	`<indexterm><primary>CREATE_REPLICATION_SLOT</primary></indexterm>`
`1992`	`1992`	`</term>`
`1993`	`1993`	`<listitem>`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ base_backup:`
`174`	`174`	`;`
`175`	`175`
`176`	`176`	`create_replication_slot:`
`177`		`-/* CREATE_REPLICATION_SLOT slot TEMPORARY PHYSICAL [options]*/`
	`177`	`+/* CREATE_REPLICATION_SLOT slot[TEMPORARY] PHYSICAL [options]*/`
`178`	`178`	`K_CREATE_REPLICATION_SLOTIDENTopt_temporaryK_PHYSICALcreate_slot_options`
`179`	`179`	`{`
`180`	`180`	`CreateReplicationSlotCmd *cmd;`
`@@ -185,7 +185,7 @@ create_replication_slot:`
`185`	`185`	`cmd->options =$5;`
`186`	`186`	`$$ = (Node *) cmd;`
`187`	`187`	`}`
`188`		`-/* CREATE_REPLICATION_SLOT slot TEMPORARY LOGICAL plugin [options]*/`
	`188`	`+/* CREATE_REPLICATION_SLOT slot[TEMPORARY] LOGICAL plugin [options]*/`
`189`	`189`	`\|K_CREATE_REPLICATION_SLOTIDENTopt_temporaryK_LOGICALIDENTcreate_slot_options`
`190`	`190`	`{`
`191`	`191`	`CreateReplicationSlotCmd *cmd;`

Comments

(0)