NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit91287b5

committed

psql: Add tests for repeated calls of \bind[_named]

The implementation assumes that on multiple calls of these meta-commandsthe last one wins. Multiple \g calls in-between mean multipleexecutions.There were no tests to check these properties, hence let's addsomething.Author: Jelte Fennema-Nio, Michael PaquierDiscussion:https://postgr.es/m/CAGECzQSTE7CoM=Gst56Xj8pOvjaPr09+7jjtWqTC40pGETyAuA@mail.gmail.com

1 parent658fc6c commit91287b5Copy full SHA for 91287b5

File tree

2 files changed

+47

-0

lines changed

src/test/regress
- expected
  - psql.out
- sql
  - psql.sql

2 files changed

+47

-0

lines changed

`‎src/test/regress/expected/psql.out`

Lines changed: 38 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,25 @@ SELECT $1, $2 \parse stmt3`
`141`	`141`	`ERROR: there is no parameter $1`
`142`	`142`	`LINE 1: SELECT $1, $2`
`143`	`143`	`^`
	`144`	`+-- Last \bind_named wins`
	`145`	`+\bind_named stmt2 'foo' \bind_named stmt3 'foo2' 'bar2' \g`
	`146`	`+ ?column? \| ?column?`
	`147`	`+----------+----------`
	`148`	`+ foo2 \| bar2`
	`149`	`+(1 row)`
	`150`	`+`
	`151`	`+-- Multiple \g calls mean multiple executions`
	`152`	`+\bind_named stmt2 'foo3' \g \bind_named stmt3 'foo4' 'bar4' \g`
	`153`	`+ ?column?`
	`154`	`+----------`
	`155`	`+ foo3`
	`156`	`+(1 row)`
	`157`	`+`
	`158`	`+ ?column? \| ?column?`
	`159`	`+----------+----------`
	`160`	`+ foo4 \| bar4`
	`161`	`+(1 row)`
	`162`	`+`
`144`	`163`	`-- \close (extended query protocol)`
`145`	`164`	`\close`
`146`	`165`	`\close: missing required argument`
`@@ -173,6 +192,25 @@ SELECT $1, $2 \bind 'foo' 'bar' \g`
`173`	`192`	`foo \| bar`
`174`	`193`	`(1 row)`
`175`	`194`
	`195`	`+-- last \bind wins`
	`196`	`+select $1::int as col \bind 'foo' \bind 2 \g`
	`197`	`+ col`
	`198`	`+-----`
	`199`	`+ 2`
	`200`	`+(1 row)`
	`201`	`+`
	`202`	`+-- Multiple \g calls mean multiple executions`
	`203`	`+select $1::int as col \bind 1 \g \bind 2 \g`
	`204`	`+ col`
	`205`	`+-----`
	`206`	`+ 1`
	`207`	`+(1 row)`
	`208`	`+`
	`209`	`+ col`
	`210`	`+-----`
	`211`	`+ 2`
	`212`	`+(1 row)`
	`213`	`+`
`176`	`214`	`-- errors`
`177`	`215`	`-- parse error`
`178`	`216`	`SELECT foo \bind \g`

`‎src/test/regress/sql/psql.sql`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,10 @@ SELECT $1, $2 \parse stmt3`
`63`	`63`	`\bind_named stmt4`
`64`	`64`	`\bind_named`
`65`	`65`	`\g`
	`66`	`+-- Last \bind_named wins`
	`67`	`+\bind_named stmt2'foo' \bind_named stmt3'foo2''bar2' \g`
	`68`	`+-- Multiple \g calls mean multiple executions`
	`69`	`+\bind_named stmt2'foo3' \g \bind_named stmt3'foo4''bar4' \g`
`66`	`70`
`67`	`71`	`-- \close (extended query protocol)`
`68`	`72`	`\close`
`@@ -76,6 +80,11 @@ SELECT 1 \bind \g`
`76`	`80`	`SELECT $1 \bind'foo' \g`
`77`	`81`	`SELECT $1, $2 \bind'foo''bar' \g`
`78`	`82`
	`83`	`+-- last \bind wins`
	`84`	`+select $1::intas col \bind'foo' \bind2 \g`
	`85`	`+-- Multiple \g calls mean multiple executions`
	`86`	`+select $1::intas col \bind1 \g \bind2 \g`
	`87`	`+`
`79`	`88`	`-- errors`
`80`	`89`	`-- parse error`
`81`	`90`	`SELECT foo \bind \g`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit91287b5

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/psql.out`

`‎src/test/regress/sql/psql.sql`

0 commit comments