Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit90a4b64

Browse files
committed
regress: fix test instability
Having additional triggers in a test table made the ORDER BY clauses inold queries underspecified. Add another column there for stability.Per sporadic buildfarm pink.
1 parent6b41a15 commit90a4b64

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

‎src/test/regress/expected/triggers.out

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2685,7 +2685,7 @@ create trigger tg_stmt after insert on parent
26852685
for statement execute procedure trig_nothing();
26862686
select tgrelid::regclass, tgname, tgenabled from pg_trigger
26872687
where tgrelid in ('parent'::regclass, 'child1'::regclass)
2688-
order by tgrelid::regclass::text;
2688+
order by tgrelid::regclass::text, tgname;
26892689
tgrelid | tgname | tgenabled
26902690
---------+---------+-----------
26912691
child1 | tg | O
@@ -2697,7 +2697,7 @@ alter table only parent enable always trigger tg;-- no recursion because ONLY
26972697
alter table parent enable always trigger tg_stmt;-- no recursion because statement trigger
26982698
select tgrelid::regclass, tgname, tgenabled from pg_trigger
26992699
where tgrelid in ('parent'::regclass, 'child1'::regclass)
2700-
order by tgrelid::regclass::text;
2700+
order by tgrelid::regclass::text, tgname;
27012701
tgrelid | tgname | tgenabled
27022702
---------+---------+-----------
27032703
child1 | tg | O
@@ -2710,7 +2710,7 @@ select tgrelid::regclass, tgname, tgenabled from pg_trigger
27102710
alter table parent enable always trigger tg;
27112711
select tgrelid::regclass, tgname, tgenabled from pg_trigger
27122712
where tgrelid in ('parent'::regclass, 'child1'::regclass)
2713-
order by tgrelid::regclass::text;
2713+
order by tgrelid::regclass::text, tgname;
27142714
tgrelid | tgname | tgenabled
27152715
---------+---------+-----------
27162716
child1 | tg | A

‎src/test/regress/sql/triggers.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1869,18 +1869,18 @@ create trigger tg_stmt after insert on parent
18691869
for statement execute procedure trig_nothing();
18701870
select tgrelid::regclass, tgname, tgenabledfrom pg_trigger
18711871
where tgrelidin ('parent'::regclass,'child1'::regclass)
1872-
order by tgrelid::regclass::text;
1872+
order by tgrelid::regclass::text, tgname;
18731873
altertable only parent enable always trigger tg;-- no recursion because ONLY
18741874
altertable parent enable always trigger tg_stmt;-- no recursion because statement trigger
18751875
select tgrelid::regclass, tgname, tgenabledfrom pg_trigger
18761876
where tgrelidin ('parent'::regclass,'child1'::regclass)
1877-
order by tgrelid::regclass::text;
1877+
order by tgrelid::regclass::text, tgname;
18781878
-- The following is a no-op for the parent trigger but not so
18791879
-- for the child trigger, so recursion should be applied.
18801880
altertable parent enable always trigger tg;
18811881
select tgrelid::regclass, tgname, tgenabledfrom pg_trigger
18821882
where tgrelidin ('parent'::regclass,'child1'::regclass)
1883-
order by tgrelid::regclass::text;
1883+
order by tgrelid::regclass::text, tgname;
18841884
droptable parent, child1;
18851885

18861886
-- Verify that firing state propagates correctly on creation, too

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp