Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit9061fd2

Browse files
committed
Avoid dangling-pointer problem with partitionwise joins under GEQO.
build_child_join_sjinfo creates a derived SpecialJoinInfo inthe short-lived GEQO context, but afterwards the semi_rhs_exprsfrom that may be used in a UniquePath for a child base relation.This breaks the expectation that all base-relation-level structuresare in the planning-lifespan context, leading to use of a danglingpointer with probable ensuing crash later on in create_unique_plan.To fix, copy the expression trees when making a UniquePath.Per bug #18360 from Alexander Lakhin. This has been broken sincepartitionwise joins were added, so back-patch to all supportedbranches.Discussion:https://postgr.es/m/18360-a23caf3157f34e62@postgresql.org
1 parenteb1d008 commit9061fd2

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

‎src/backend/optimizer/util/pathnode.c‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1622,8 +1622,13 @@ create_unique_path(PlannerInfo *root, RelOptInfo *rel, Path *subpath,
16221622
pathnode->path.pathkeys=NIL;
16231623

16241624
pathnode->subpath=subpath;
1625-
pathnode->in_operators=sjinfo->semi_operators;
1626-
pathnode->uniq_exprs=sjinfo->semi_rhs_exprs;
1625+
1626+
/*
1627+
* Under GEQO, the sjinfo might be short-lived, so we'd better make copies
1628+
* of data structures we extract from it.
1629+
*/
1630+
pathnode->in_operators=copyObject(sjinfo->semi_operators);
1631+
pathnode->uniq_exprs=copyObject(sjinfo->semi_rhs_exprs);
16271632

16281633
/*
16291634
* If the input is a relation and it has a unique index that proves the

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp