Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit904af8d

Browse files
committed
Fix handling of strict non-set functions with NULLs in set-valued inputs.
In a construct like "select plain_function(set_returning_function(...))",the plain function is applied to each output row of the SRF successively.If some of the SRF outputs are NULL, and the plain function is strict,you'd expect to get NULL results for such rows ... but what actuallyhappened was that such rows were omitted entirely from the result set.This was due to confusion of this case with what should happen for nestedset-returning functions; a strict SRF is indeed supposed to yield an emptyset for null input. Per bug #8150 from Erwin Brandstetter.Although this has been broken forever, we're not back-patching becauseof the possibility that some apps out there expect the incorrect behavior.This change should be listed as a possible incompatibility in the 9.3release notes.
1 parentf0ed3a8 commit904af8d

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

‎src/backend/executor/execQual.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1801,12 +1801,20 @@ ExecMakeFunctionResult(FuncExprState *fcache,
18011801
pgstat_end_function_usage(&fcusage,
18021802
rsinfo.isDone!=ExprMultipleResult);
18031803
}
1804-
else
1804+
elseif (fcache->func.fn_retset)
18051805
{
1806+
/* for a strict SRF, result for NULL is an empty set */
18061807
result= (Datum)0;
18071808
*isNull= true;
18081809
*isDone=ExprEndResult;
18091810
}
1811+
else
1812+
{
1813+
/* for a strict non-SRF, result for NULL is a NULL */
1814+
result= (Datum)0;
1815+
*isNull= true;
1816+
*isDone=ExprSingleResult;
1817+
}
18101818

18111819
/* Which protocol does function want to use? */
18121820
if (rsinfo.returnMode==SFRM_ValuePerCall)

‎src/test/regress/expected/arrays.out

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1542,6 +1542,15 @@ select unnest(array[1,2,3,null,4,null,null,5,6]::text[]);
15421542
6
15431543
(9 rows)
15441544

1545+
select abs(unnest(array[1,2,null,-3]));
1546+
abs
1547+
-----
1548+
1
1549+
2
1550+
1551+
3
1552+
(4 rows)
1553+
15451554
select array_remove(array[1,2,2,3], 2);
15461555
array_remove
15471556
--------------

‎src/test/regress/sql/arrays.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,7 @@ select unnest(array[1,2,3,4.5]::float8[]);
432432
select unnest(array[1,2,3,4.5]::numeric[]);
433433
select unnest(array[1,2,3,null,4,null,null,5,6]);
434434
select unnest(array[1,2,3,null,4,null,null,5,6]::text[]);
435+
select abs(unnest(array[1,2,null,-3]));
435436
select array_remove(array[1,2,2,3],2);
436437
select array_remove(array[1,2,2,3],5);
437438
select array_remove(array[1,NULL,NULL,3],NULL);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp