NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9016a2a

committed

Fix breakage of get_ps_display() in the PS_USE_NONE case.

Commit8c6d30f caused this function to fail to set *displenin the PS_USE_NONE code path. If the variable's previous valuehad been negative, that'd lead to a memory clobber at some callsites. We'd managed not to notice due to very thin test coverageof such configurations, but this appears to explain buildfarm memberlorikeet's recent struggles.Credit to Andrew Dunstan for spotting the problem. Back-patchto v13 where the bug was introduced.Discussion:https://postgr.es/m/136102.1648320427@sss.pgh.pa.us

1 parent3d4d6de commit9016a2aCopy full SHA for 9016a2a

File tree

1 file changed

-0

lines changed

src/backend/utils/misc
- ps_status.c

1 file changed

-0

lines changed

`‎src/backend/utils/misc/ps_status.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -443,6 +443,7 @@ get_ps_display(int *displen)`
`443`	`443`
`444`	`444`	`returnps_buffer+ps_buffer_fixed_size;`
`445`	`445`	`#else`
	`446`	`+*displen=0;`
`446`	`447`	`return"";`
`447`	`448`	`#endif`
`448`	`449`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9016a2a

File tree

1 file changed

1 file changed

`‎src/backend/utils/misc/ps_status.c`

0 commit comments