NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit9010156

committed

Fix thinko introduced by82a5649 in slot.c

When saving a replication slot, failing to close the temporary path usedto save the slot information is considered as a failure and reported assuch. However the code forgot to leave immediately as other failurepaths do.Noticed while looking up at this area of the code for another patch.

1 parent47ac203 commit9010156Copy full SHA for 9010156

File tree

1 file changed

-0

lines changed

src/backend/replication
- slot.c

1 file changed

-0

lines changed

`‎src/backend/replication/slot.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1316,10 +1316,13 @@ SaveSlotToPath(ReplicationSlot slot, const char dir, int elevel)`
`1316`	`1316`	`pgstat_report_wait_end();`
`1317`	`1317`
`1318`	`1318`	`if (CloseTransientFile(fd))`
	`1319`	`+{`
`1319`	`1320`	`ereport(elevel,`
`1320`	`1321`	`(errcode_for_file_access(),`
`1321`	`1322`	`errmsg("could not close file \"%s\": %m",`
`1322`	`1323`	`tmppath)));`
	`1324`	`+return;`
	`1325`	`+}`
`1323`	`1326`
`1324`	`1327`	`/* rename to permanent file, fsync file and directory */`
`1325`	`1328`	`if (rename(tmppath,path)!=0)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9010156

File tree

1 file changed

1 file changed

`‎src/backend/replication/slot.c`

0 commit comments