Commit9003b76

committed

Initialize dblink remoteConn struct in all cases

Two of the members of rconn were left uninitialized. Whendblink_open() is called without an outer transaction ithandles the initialization for us, but with an outertransaction it does not. Arrange for initializationin all cases. Backpatch to all supported versions.Reported-by: Alexander LakhinDiscussion:https://www.postgresql.org/message-id/flat/9bd0744f-5f04-c778-c5b3-809efe9c30c7%40joeconway.com#c545909a41664991aca60c4d70a10ce7

1 parent887cdff commit9003b76Copy full SHA for 9003b76

File tree

-0

lines changed

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -298,8 +298,13 @@ dblink_connect(PG_FUNCTION_ARGS)`
`298`	`298`	`conname_or_str=text_to_cstring(PG_GETARG_TEXT_PP(0));`
`299`	`299`
`300`	`300`	`if (connname)`
	`301`	`+{`
`301`	`302`	`rconn= (remoteConn*)MemoryContextAlloc(TopMemoryContext,`
`302`	`303`	`sizeof(remoteConn));`
	`304`	`+rconn->conn=NULL;`
	`305`	`+rconn->openCursorCount=0;`
	`306`	`+rconn->newXactForCursor= false;`
	`307`	`+}`
`303`	`308`
`304`	`309`	`/* first check for valid foreign data server */`
`305`	`310`	`connstr=get_connect_string(conname_or_str);`

Comments

(0)