Commit8f87dcd

committed

Update new pg_upgrade comment about pre-8.4 TOAST tables.

1 parent9e5bed2 commit8f87dcdCopy full SHA for 8f87dcd

File tree

-1

lines changed

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,11 @@ gen_db_file_maps(DbInfo old_db, DbInfo new_db,`
`54`	`54`	`pg_log(PG_FATAL,"Mismatch of relation id: database \"%s\", old relid %d, new relid %d\n",`
`55`	`55`	`old_db->db_name,old_rel->reloid,new_rel->reloid);`
`56`	`56`
`57`		`-/* toast names were not renamed to match their relfilenodes in pre-8.4 */`
	`57`	`+/*`
	`58`	`+ *In pre-8.4, TOAST table names change during CLUSTER; in >= 8.4`
	`59`	`+ *TOAST relation names always use the heap tables oid, hence we`
	`60`	`+ *cannot check relation names when upgrading from pre-8.4.`
	`61`	`+ */`
`58`	`62`	`if (GET_MAJOR_VERSION(old_cluster.major_version) >=804&&`
`59`	`63`	`(strcmp(old_rel->nspname,new_rel->nspname)!=0\|\|`
`60`	`64`	`strcmp(old_rel->relname,new_rel->relname)!=0))`

Comments

(0)