NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8f76324

committed

Report Python errors from iterators with PLy_elog

This improves reporting, as the error string now includes the actualPython exception. As a side effect, this no longer sets the errcode toERRCODE_DATA_EXCEPTION, which might be considered a feature, as it'snot documented and not clear why iterator errors should be treateddifferently.Jan Urbański

1 parentcfcdc99 commit8f76324Copy full SHA for 8f76324

File tree

1 file changed

-3

lines changed

src/pl/plpython
- plpython.c

1 file changed

-3

lines changed

`‎src/pl/plpython/plpython.c`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1157,9 +1157,7 @@ PLy_function_handler(FunctionCallInfo fcinfo, PLyProcedure *proc)`
`1157`	`1157`	`PLy_function_delete_args(proc);`
`1158`	`1158`
`1159`	`1159`	`if (has_error)`
`1160`		`-ereport(ERROR,`
`1161`		`-(errcode(ERRCODE_DATA_EXCEPTION),`
`1162`		`-errmsg("error fetching next item from iterator")));`
	`1160`	`+PLy_elog(ERROR,"error fetching next item from iterator");`
`1163`	`1161`
`1164`	`1162`	`/* Disconnect from the SPI manager before returning */`
`1165`	`1163`	`if (SPI_finish()!=SPI_OK_FINISH)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8f76324

File tree

1 file changed

1 file changed

`‎src/pl/plpython/plpython.c`

0 commit comments