Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit8f67f99

Browse files
committed
Fix handling of orphaned 2PC files in the future at recovery
Before728bd99, that has improved the support for 2PC files duringrecovery, the initial logic scanning files in pg_twophase was done so asfiles in the future of the transaction ID horizon were checked first,followed by a check if a transaction ID is aborted or committed whichcould involve a pg_xact lookup. After this commit, these checks havebeen done in reverse order.Files detected as in the future do not have a state that can be checkedin pg_xact, hence this caused recovery to fail abruptly should anorphaned 2PC file in the future of the transaction ID horizon exist inpg_twophase at the beginning of recovery.A test is added to check for this scenario, using an empty 2PC with atransaction ID large enough to be in the future when running the test.This test is added in 16 and older versions for now. 17 and newerversions are impacted by a second bug caused by the addition of theepoch in the 2PC file names. An equivalent test will be added in thesebranches in a follow-up commit, once the second set of issues reportedare fixed.Author: Vitaly Davydov, Michael PaquierDiscussion:https://postgr.es/m/11e597-676ab680-8d-374f23c0@145466129Backpatch-through: 13
1 parent70d067c commit8f67f99

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

‎src/backend/access/transam/twophase.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2167,40 +2167,40 @@ ProcessTwoPhaseBuffer(TransactionId xid,
21672167
if (!fromdisk)
21682168
Assert(prepare_start_lsn!=InvalidXLogRecPtr);
21692169

2170-
/*Already processed? */
2171-
if (TransactionIdDidCommit(xid)||TransactionIdDidAbort(xid))
2170+
/*Reject XID if too new */
2171+
if (TransactionIdFollowsOrEquals(xid,origNextXid))
21722172
{
21732173
if (fromdisk)
21742174
{
21752175
ereport(WARNING,
2176-
(errmsg("removingstale two-phase state file for transaction %u",
2176+
(errmsg("removingfuture two-phase state file for transaction %u",
21772177
xid)));
21782178
RemoveTwoPhaseFile(xid, true);
21792179
}
21802180
else
21812181
{
21822182
ereport(WARNING,
2183-
(errmsg("removingstale two-phase state from memory for transaction %u",
2183+
(errmsg("removingfuture two-phase state from memory for transaction %u",
21842184
xid)));
21852185
PrepareRedoRemove(xid, true);
21862186
}
21872187
returnNULL;
21882188
}
21892189

2190-
/*Reject XID if too new */
2191-
if (TransactionIdFollowsOrEquals(xid,origNextXid))
2190+
/*Already processed? */
2191+
if (TransactionIdDidCommit(xid)||TransactionIdDidAbort(xid))
21922192
{
21932193
if (fromdisk)
21942194
{
21952195
ereport(WARNING,
2196-
(errmsg("removingfuture two-phase state file for transaction %u",
2196+
(errmsg("removingstale two-phase state file for transaction %u",
21972197
xid)));
21982198
RemoveTwoPhaseFile(xid, true);
21992199
}
22002200
else
22012201
{
22022202
ereport(WARNING,
2203-
(errmsg("removingfuture two-phase state from memory for transaction %u",
2203+
(errmsg("removingstale two-phase state from memory for transaction %u",
22042204
xid)));
22052205
PrepareRedoRemove(xid, true);
22062206
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp