NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8f65c02

committed

Remove the currently unused FRONTEND case in dllist.c. This allows the usage

of palloc instead of malloc, which means a list can be freed simply by deletingthe memory context that contains it.

1 parentbb8998a commit8f65c02Copy full SHA for 8f65c02

File tree

1 file changed

-36

lines changed

src/backend/lib
- dllist.c

1 file changed

-36

lines changed

`‎src/backend/lib/dllist.c`

Lines changed: 8 additions & 36 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,19 +9,11 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $PostgreSQL: pgsql/src/backend/lib/dllist.c,v 1.34 2007/01/05 22:19:29 momjian Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/lib/dllist.c,v 1.35 2007/03/22 18:57:52 alvherre Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`16`		`-`
`17`		`-/* can be used in frontend or backend */`
`18`		`-#ifdefFRONTEND`
`19`		`-#include"postgres_fe.h"`
`20`		`-/* No assert checks in frontend ... */`
`21`		`-#defineAssert(condition)`
`22`		`-#else`
`23`	`16`	`#include"postgres.h"`
`24`		`-#endif`
`25`	`17`
`26`	`18`	`#include"lib/dllist.h"`
`27`	`19`
`@@ -31,18 +23,8 @@ DLNewList(void)`
`31`	`23`	`{`
`32`	`24`	`Dllist*l;`
`33`	`25`
`34`		`-l= (Dllist*)malloc(sizeof(Dllist));`
`35`		`-if (l==NULL)`
`36`		`-{`
`37`		`-#ifdefFRONTEND`
`38`		`-fprintf(stderr,"memory exhausted in DLNewList\n");`
`39`		`-exit(1);`
`40`		`-#else`
`41`		`-ereport(ERROR,`
`42`		`-(errcode(ERRCODE_OUT_OF_MEMORY),`
`43`		`-errmsg("out of memory")));`
`44`		`-#endif`
`45`		`-}`
	`26`	`+l= (Dllist*)palloc(sizeof(Dllist));`
	`27`	`+`
`46`	`28`	`l->dll_head=NULL;`
`47`	`29`	`l->dll_tail=NULL;`
`48`	`30`
`@@ -66,28 +48,18 @@ DLFreeList(Dllist *list)`
`66`	`48`	`Dlelem*curr;`
`67`	`49`
`68`	`50`	`while ((curr=DLRemHead(list))!=NULL)`
`69`		`-free(curr);`
	`51`	`+pfree(curr);`
`70`	`52`
`71`		`-free(list);`
	`53`	`+pfree(list);`
`72`	`54`	`}`
`73`	`55`
`74`	`56`	`Dlelem*`
`75`	`57`	`DLNewElem(void*val)`
`76`	`58`	`{`
`77`	`59`	`Dlelem*e;`
`78`	`60`
`79`		`-e= (Dlelem*)malloc(sizeof(Dlelem));`
`80`		`-if (e==NULL)`
`81`		`-{`
`82`		`-#ifdefFRONTEND`
`83`		`-fprintf(stderr,"memory exhausted in DLNewElem\n");`
`84`		`-exit(1);`
`85`		`-#else`
`86`		`-ereport(ERROR,`
`87`		`-(errcode(ERRCODE_OUT_OF_MEMORY),`
`88`		`-errmsg("out of memory")));`
`89`		`-#endif`
`90`		`-}`
	`61`	`+e= (Dlelem*)palloc(sizeof(Dlelem));`
	`62`	`+`
`91`	`63`	`e->dle_next=NULL;`
`92`	`64`	`e->dle_prev=NULL;`
`93`	`65`	`e->dle_val=val;`
`@@ -107,7 +79,7 @@ DLInitElem(Dlelem e, void val)`
`107`	`79`	`void`
`108`	`80`	`DLFreeElem(Dlelem*e)`
`109`	`81`	`{`
`110`		`-free(e);`
	`82`	`+pfree(e);`
`111`	`83`	`}`
`112`	`84`
`113`	`85`	`void`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8f65c02

File tree

1 file changed

1 file changed

`‎src/backend/lib/dllist.c`

0 commit comments