forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit8f32299
committed
Detect unused steps in isolation specs and do some cleanup
This is useful for developers to find out if an isolation spec isover-engineered or if it needs more work by warning at the end of atest run if a step is not used, generating a failure with extra diffs.While on it, clean up all the specs which include steps not used in anypermutations to simplify them.This is a backpatch of989d23b and06fdc4e, as it is becoming useful tomake all the branches consistent for an upcoming patch that will improvethe output generated by isolationtester.Author: Michael PaquierReviewed-by: Asim Praveen, Melanie PlagemanDiscussion:https://postgr.es/m/20190819080820.GG18166@paquier.xyzDiscussion:https://postgr.es/m/794820.1623872009@sss.pgh.pa.usBackpatch-through: 9.61 parent834cb72 commit8f32299
File tree
14 files changed
+40
-42
lines changed- contrib/test_decoding/specs
- src/test/isolation
- expected
- specs
14 files changed
+40
-42
lines changedLines changed: 0 additions & 9 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
19 | 19 |
| |
20 | 20 |
| |
21 | 21 |
| |
22 |
| - | |
23 | 22 |
| |
24 | 23 |
| |
25 | 24 |
| |
| |||
29 | 28 |
| |
30 | 29 |
| |
31 | 30 |
| |
32 |
| - | |
33 | 31 |
| |
34 | 32 |
| |
35 |
| - | |
36 |
| - | |
37 |
| - | |
38 |
| - | |
39 |
| - | |
40 |
| - | |
41 | 33 |
| |
42 | 34 |
| |
43 | 35 |
| |
| |||
46 | 38 |
| |
47 | 39 |
| |
48 | 40 |
| |
49 |
| - | |
50 | 41 |
| |
51 | 42 |
| |
52 | 43 |
| |
|
Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
25 | 25 |
| |
26 | 26 |
| |
27 | 27 |
| |
28 |
| - | |
29 | 28 |
| |
30 | 29 |
| |
31 | 30 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1 |
| - | |
| 1 | + | |
2 | 2 |
| |
3 | 3 |
| |
4 | 4 |
| |
|
Lines changed: 18 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
88 | 88 |
| |
89 | 89 |
| |
90 | 90 |
| |
91 |
| - | |
| 91 | + | |
92 | 92 |
| |
93 | 93 |
| |
94 | 94 |
| |
| |||
252 | 252 |
| |
253 | 253 |
| |
254 | 254 |
| |
| 255 | + | |
| 256 | + | |
255 | 257 |
| |
256 | 258 |
| |
257 | 259 |
| |
258 | 260 |
| |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
259 | 272 |
| |
260 | 273 |
| |
261 | 274 |
| |
| |||
455 | 468 |
| |
456 | 469 |
| |
457 | 470 |
| |
| 471 | + | |
| 472 | + | |
| 473 | + | |
458 | 474 |
| |
| 475 | + | |
459 | 476 |
| |
460 | 477 |
| |
461 | 478 |
| |
|
Lines changed: 1 addition & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
29 | 29 |
| |
30 | 30 |
| |
31 | 31 |
| |
| 32 | + | |
32 | 33 |
| |
33 | 34 |
| |
34 | 35 |
| |
|
Lines changed: 1 addition & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
145 | 145 |
| |
146 | 146 |
| |
147 | 147 |
| |
| 148 | + | |
148 | 149 |
| |
149 | 150 |
| |
150 | 151 |
| |
|
Lines changed: 19 additions & 19 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
113 | 113 |
| |
114 | 114 |
| |
115 | 115 |
| |
116 |
| - | |
| 116 | + | |
117 | 117 |
| |
118 | 118 |
| |
119 | 119 |
| |
| |||
153 | 153 |
| |
154 | 154 |
| |
155 | 155 |
| |
156 |
| - | |
| 156 | + | |
157 | 157 |
| |
158 |
| - | |
159 |
| - | |
160 |
| - | |
161 |
| - | |
162 |
| - | |
163 |
| - | |
164 |
| - | |
165 |
| - | |
166 |
| - | |
167 |
| - | |
168 |
| - | |
169 |
| - | |
170 |
| - | |
171 |
| - | |
172 |
| - | |
173 |
| - | |
174 |
| - | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
175 | 175 |
| |
176 | 176 |
| |
177 | 177 |
| |
|
Lines changed: 0 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
19 | 19 |
| |
20 | 20 |
| |
21 | 21 |
| |
22 |
| - | |
23 | 22 |
| |
24 | 23 |
| |
25 | 24 |
| |
| |||
28 | 27 |
| |
29 | 28 |
| |
30 | 29 |
| |
31 |
| - | |
32 | 30 |
| |
33 | 31 |
| |
34 | 32 |
| |
| |||
40 | 38 |
| |
41 | 39 |
| |
42 | 40 |
| |
43 |
| - | |
44 | 41 |
| |
45 | 42 |
| |
46 | 43 |
| |
|
Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
33 | 33 |
| |
34 | 34 |
| |
35 | 35 |
| |
36 |
| - | |
37 | 36 |
| |
38 | 37 |
| |
39 | 38 |
| |
|
Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
32 | 32 |
| |
33 | 33 |
| |
34 | 34 |
| |
35 |
| - | |
36 | 35 |
| |
37 | 36 |
| |
38 | 37 |
| |
|
Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
30 | 30 |
| |
31 | 31 |
| |
32 | 32 |
| |
33 |
| - | |
34 | 33 |
| |
35 | 34 |
| |
36 | 35 |
| |
|
Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
57 | 57 |
| |
58 | 58 |
| |
59 | 59 |
| |
60 |
| - | |
61 | 60 |
| |
62 | 61 |
| |
63 | 62 |
| |
|
Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
15 | 15 |
| |
16 | 16 |
| |
17 | 17 |
| |
18 |
| - | |
19 | 18 |
| |
20 | 19 |
| |
21 | 20 |
| |
|
Lines changed: 0 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
19 | 19 |
| |
20 | 20 |
| |
21 | 21 |
| |
22 |
| - | |
23 | 22 |
| |
24 | 23 |
| |
25 | 24 |
| |
| |||
28 | 27 |
| |
29 | 28 |
| |
30 | 29 |
| |
31 |
| - | |
32 | 30 |
| |
33 | 31 |
| |
34 | 32 |
| |
| |||
44 | 42 |
| |
45 | 43 |
| |
46 | 44 |
| |
47 |
| - | |
48 | 45 |
| |
49 | 46 |
| |
50 | 47 |
| |
|
0 commit comments
Comments
(0)