NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8f0d8f4

committed

Fix one-byte buffer overrun in PQprintTuples().

This bug goes back to the original Postgres95 sources. Its significanceto modern PG versions is marginal, since we have not used PQprintTuples()internally in a very long time, and it doesn't seem to have ever beendocumented either. Still, it *is* exposed to client apps, so somebodyout there might possibly be using it.Xi Wang

1 parent535e69a commit8f0d8f4Copy full SHA for 8f0d8f4

File tree

1 file changed

-4

lines changed

src/interfaces/libpq
- fe-print.c

1 file changed

-4

lines changed

`‎src/interfaces/libpq/fe-print.c`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -681,7 +681,6 @@ PQprintTuples(const PGresult *res,`
`681`	`681`	`inti,`
`682`	`682`	`j;`
`683`	`683`	`charformatString[80];`
`684`		`-`
`685`	`684`	`char*tborder=NULL;`
`686`	`685`
`687`	`686`	`nFields=PQnfields(res);`
`@@ -700,15 +699,15 @@ PQprintTuples(const PGresult *res,`
`700`	`699`	`intwidth;`
`701`	`700`
`702`	`701`	`width=nFields*14;`
`703`		`-tborder=malloc(width+1);`
	`702`	`+tborder=(char*)malloc(width+1);`
`704`	`703`	`if (!tborder)`
`705`	`704`	`{`
`706`	`705`	`fprintf(stderr,libpq_gettext("out of memory\n"));`
`707`	`706`	`abort();`
`708`	`707`	`}`
`709`		`-for (i=0;i <=width;i++)`
	`708`	`+for (i=0;i<width;i++)`
`710`	`709`	`tborder[i]='-';`
`711`		`-tborder[i]='\0';`
	`710`	`+tborder[width]='\0';`
`712`	`711`	`fprintf(fout,"%s\n",tborder);`
`713`	`712`	`}`
`714`	`713`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8f0d8f4

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-print.c`

0 commit comments