NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8ea71fd

committed

Modernize zic's test for valid timezone abbreviations.

We really need to sync all of our IANA-derived timezone code with upstream,but that's going to be a large patch and I certainly don't care to shovesuch a thing into stable branches immediately before a release. As astopgap, copy just the tzcode2016c logic that checks validity of timezoneabbreviations. This prevents getting multiple "time zone abbreviationdiffers from POSIX standard" bleats with tzdata 2014b and later.

1 parent8e16592 commit8ea71fdCopy full SHA for 8ea71fd

File tree

1 file changed

-20

lines changed

src/timezone
- zic.c

1 file changed

-20

lines changed

`‎src/timezone/zic.c`

Lines changed: 5 additions & 20 deletions

Original file line number	Diff line number	Diff line change
`@@ -2796,30 +2796,15 @@ newabbr(const char *string)`
`2796`	`2796`	`constchar*cp;`
`2797`	`2797`	`char*wp;`
`2798`	`2798`
`2799`		`-/*`
`2800`		`- * Want one to ZIC_MAX_ABBR_LEN_WO_WARN alphabetics optionally`
`2801`		`- * followed by a + or - and a number from 1 to 14.`
`2802`		`- */`
`2803`	`2799`	`cp=string;`
`2804`	`2800`	`wp=NULL;`
`2805`		`-while (isascii((unsignedchar)*cp)&&`
`2806`		`-isalpha((unsignedchar)*cp))`
	`2801`	`+while (isalpha((unsignedchar)cp)\|\| ('0' <=cp&&*cp <='9')`
	`2802`	`+\|\|cp=='-'\|\|cp=='+')`
`2807`	`2803`	`++cp;`
`2808`		`-if (cp-string==0)`
`2809`		`-wp=_("time zone abbreviation lacks alphabetic at start");`
`2810`		`-if (noise&&cp-string>3)`
`2811`		`-wp=_("time zone abbreviation has more than 3 alphabetics");`
	`2804`	`+if (noise&&cp-string<3)`
	`2805`	`+wp=_("time zone abbreviation has fewer than 3 characters");`
`2812`	`2806`	`if (cp-string>ZIC_MAX_ABBR_LEN_WO_WARN)`
`2813`		`-wp=_("time zone abbreviation has too many alphabetics");`
`2814`		`-if (wp==NULL&& (cp=='+'\|\|cp=='-'))`
`2815`		`-{`
`2816`		`-++cp;`
`2817`		`-if (isascii((unsignedchar)*cp)&&`
`2818`		`-isdigit((unsignedchar)*cp))`
`2819`		`-if (*cp++=='1'&&`
`2820`		`-cp >='0'&&cp <='4')`
`2821`		`-++cp;`
`2822`		`-}`
	`2807`	`+wp=_("time zone abbreviation has too many characters");`
`2823`	`2808`	`if (*cp!='\0')`
`2824`	`2809`	`wp=_("time zone abbreviation differs from POSIX standard");`
`2825`	`2810`	`if (wp!=NULL)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8ea71fd

File tree

1 file changed

1 file changed

`‎src/timezone/zic.c`

0 commit comments