Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit8e40d16

Browse files
committed
pg_upgrade: Fix some minor code issues
96ef3b8 accidentally copied a notapplicable comment from the float8_pass_by_value code to thedata_checksums code. Remove that.87d3b35 changed pg_upgrade tochecking the checksum version rather than just the Boolean presence ofchecksums, but didn't change the field type in its ControlData structfrom bool. So this would not work correctly if there ever is achecksum version larger than 1.
1 parent1a2ad6e commit8e40d16

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

‎src/bin/pg_upgrade/controldata.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,6 @@ get_control_data(ClusterInfo *cluster, bool live_check)
493493
pg_fatal("%d: controldata retrieval problem\n",__LINE__);
494494

495495
p++;/* remove ':' char */
496-
/* used later for contrib check */
497496
cluster->controldata.data_checksum_version=str2uint(p);
498497
got_data_checksum_version= true;
499498
}

‎src/bin/pg_upgrade/pg_upgrade.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ typedef struct
219219
uint32large_object;
220220
booldate_is_int;
221221
boolfloat8_pass_by_value;
222-
booldata_checksum_version;
222+
uint32data_checksum_version;
223223
}ControlData;
224224

225225
/*

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp