NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8e33fc1

committed

Call getsockopt() on the correct socket.

We're interested in the buffer size of the socket that's connected to theclient, not the one that's listening for new connections. It happened towork, as default buffer size is the same on both, but it was clearly notwrong.Spotted by Tom Lane

1 parent4f33621 commit8e33fc1Copy full SHA for 8e33fc1

File tree

1 file changed

-1

lines changed

src/backend/libpq
- pqcomm.c

1 file changed

-1

lines changed

`‎src/backend/libpq/pqcomm.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -773,7 +773,7 @@ StreamConnection(pgsocket server_fd, Port *port)`
`773`	`773`	`* https://msdn.microsoft.com/en-us/library/bb736549%28v=vs.85%29.aspx`
`774`	`774`	`*/`
`775`	`775`	`optlen=sizeof(oldopt);`
`776`		`-if (getsockopt(server_fd,SOL_SOCKET,SO_SNDBUF, (char*)&oldopt,`
	`776`	`+if (getsockopt(port->sock,SOL_SOCKET,SO_SNDBUF, (char*)&oldopt,`
`777`	`777`	`&optlen)<0)`
`778`	`778`	`{`
`779`	`779`	`elog(LOG,"getsockopt(SO_SNDBUF) failed: %m");`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8e33fc1

File tree

1 file changed

1 file changed

`‎src/backend/libpq/pqcomm.c`

0 commit comments