NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8e0c76b

committed

pg_upgrade: Upgrade an Assert to a real 'if' test

It seems possible for the condition being tested to be true inproduction, and nobody would never know (except when some dataeventually becomes corrupt?).Author: Álvaro Herrera <alvherre@alvh.no-ip.org>Discussion:https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql

1 parentc714ebd commit8e0c76bCopy full SHA for 8e0c76b

File tree

1 file changed

-1

lines changed

src/bin/pg_rewind
- parsexlog.c

1 file changed

-1

lines changed

`‎src/bin/pg_rewind/parsexlog.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,11 @@ extractPageMap(const char *datadir, XLogRecPtr startpoint, int tliIndex,`
`105`	`105`	`* If 'endpoint' didn't point exactly at a record boundary, the caller`
`106`	`106`	`* messed up.`
`107`	`107`	`*/`
`108`		`-Assert(xlogreader->EndRecPtr==endpoint);`
	`108`	`+if (xlogreader->EndRecPtr!=endpoint)`
	`109`	`+pg_fatal("end pointer %X/%X is not a valid end point; expected %X/%X",`
	`110`	`+ (uint32) (endpoint >>32), (uint32) (endpoint),`
	`111`	`+ (uint32) (xlogreader->EndRecPtr >>32), (uint32)`
	`112`	`+ (xlogreader->EndRecPtr));`
`109`	`113`
`110`	`114`	`XLogReaderFree(xlogreader);`
`111`	`115`	`if (xlogreadfd!=-1)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8e0c76b

File tree

1 file changed

1 file changed

`‎src/bin/pg_rewind/parsexlog.c`

0 commit comments