Commit8e053dc

committed

Fix possible NULL-pointer-deference in backup_compression.c.

Per Coverity and Tom Lane. Reviewed by Tom Lane and Justin Pryzby.Discussion:http://postgr.es/m/384291.1648403267@sss.pgh.pa.us

1 parent027fa0f commit8e053dcCopy full SHA for 8e053dc

File tree

+10

-2

lines changed

+10

-2

lines changed

Lines changed: 10 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -191,8 +191,16 @@ parse_bc_specification(bc_algorithm algorithm, char *specification,`
`191`	`191`	`if (value!=NULL)`
`192`	`192`	`pfree(value);`
`193`	`193`
`194`		`-/* If we got an error or have reached the end of the string, stop. */`
`195`		`-if (result->parse_error!=NULL\|\|kwend=='\0'\|\|vend=='\0')`
	`194`	`+/*`
	`195`	`+ * If we got an error or have reached the end of the string, stop.`
	`196`	`+ *`
	`197`	`+ * If there is no value, then the end of the keyword might have been`
	`198`	`+ * the end of the string. If there is a value, then the end of the`
	`199`	`+ * keyword cannot have been the end of the string, but the end of the`
	`200`	`+ * value might have been.`
	`201`	`+ */`
	`202`	`+if (result->parse_error!=NULL\|\|`
	`203`	`+(vend==NULL ?kwend=='\0' :vend=='\0'))`
`196`	`204`	`break;`
`197`	`205`
`198`	`206`	`/* Advance to next entry and loop around. */`

Comments

(0)