NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8de3b68

committed

pg_stat_activity: show NULL stmt start time for walsenders

Returning a non-NULL time is pointless, sinc a walsender is not aprocess that would be running normal transactions anyway, but the codewas unintentionally exposing the process start time intermittently,which was not only bogus but it also confused monitoring systems lookingfor idle transactions. Fix by avoiding all updates in walsenders.Backpatch to pg10: previously I misidentified the branches that showauxiliary processes in pg_stat_activity.Reported-by: Tomas VondraDiscussion:https://postgr.es/m/20191209234409.exe7osmyalwkt5j4@development

1 parent66fd0ad commit8de3b68Copy full SHA for 8de3b68

File tree

1 file changed

-0

lines changed

src/backend/access/transam
- xact.c

1 file changed

-0

lines changed

`‎src/backend/access/transam/xact.c`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -758,6 +758,13 @@ GetCurrentTransactionStopTimestamp(void)`
`758`	`758`	`void`
`759`	`759`	`SetCurrentStatementStartTimestamp(void)`
`760`	`760`	`{`
	`761`	`+/*`
	`762`	`+ * Skip if on a walsender; this is not needed, and it confuses monitoring`
	`763`	`+ * if we publish non-NULL values.`
	`764`	`+ */`
	`765`	`+if (am_walsender)`
	`766`	`+return;`
	`767`	`+`
`761`	`768`	`if (!IsParallelWorker())`
`762`	`769`	`stmtStartTimestamp=GetCurrentTimestamp();`
`763`	`770`	`else`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8de3b68

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xact.c`

0 commit comments