NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8d928e3

committed

Rename BufferAccessStrategyData.ring_size to nbuffers

The new name better reflects what the field is - the size of the buffers[]array. ring_size sounded more like it is in units of bytes.An upcoming commit allows a BufferAccessStrategy of custom sizes, so itseems relevant to improve this beforehand.Author: Melanie PlagemanReviewed-by: David RowleyDiscussion:https://postgr.es/m/CAAKRu_YefVbhg4rAxU2frYFdTap61UftH-kUNQZBvAs%2BYK81Zg%40mail.gmail.com

1 parent4830f10 commit8d928e3Copy full SHA for 8d928e3

File tree

1 file changed

-9

lines changed

src/backend/storage/buffer
- freelist.c

1 file changed

-9

lines changed

`‎src/backend/storage/buffer/freelist.c`

Lines changed: 9 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ typedef struct BufferAccessStrategyData`
`74`	`74`	`/* Overall strategy type */`
`75`	`75`	`BufferAccessStrategyTypebtype;`
`76`	`76`	`/* Number of elements in buffers[] array */`
`77`		`-intring_size;`
	`77`	`+intnbuffers;`
`78`	`78`
`79`	`79`	`/*`
`80`	`80`	`* Index of the "current" slot in the ring, ie, the one most recently`
`@@ -541,7 +541,7 @@ BufferAccessStrategy`
`541`	`541`	`GetAccessStrategy(BufferAccessStrategyTypebtype)`
`542`	`542`	`{`
`543`	`543`	`BufferAccessStrategystrategy;`
`544`		`-intring_size;`
	`544`	`+intnbuffers;`
`545`	`545`
`546`	`546`	`/*`
`547`	`547`	`* Select ring size to use. See buffer/README for rationales.`
`@@ -556,13 +556,13 @@ GetAccessStrategy(BufferAccessStrategyType btype)`
`556`	`556`	`returnNULL;`
`557`	`557`
`558`	`558`	`caseBAS_BULKREAD:`
`559`		`-ring_size=256*1024 /BLCKSZ;`
	`559`	`+nbuffers=256*1024 /BLCKSZ;`
`560`	`560`	`break;`
`561`	`561`	`caseBAS_BULKWRITE:`
`562`		`-ring_size=1610241024 /BLCKSZ;`
	`562`	`+nbuffers=1610241024 /BLCKSZ;`
`563`	`563`	`break;`
`564`	`564`	`caseBAS_VACUUM:`
`565`		`-ring_size=256*1024 /BLCKSZ;`
	`565`	`+nbuffers=256*1024 /BLCKSZ;`
`566`	`566`	`break;`
`567`	`567`
`568`	`568`	`default:`
`@@ -572,16 +572,16 @@ GetAccessStrategy(BufferAccessStrategyType btype)`
`572`	`572`	`}`
`573`	`573`
`574`	`574`	`/* Make sure ring isn't an undue fraction of shared buffers */`
`575`		`-ring_size=Min(NBuffers /8,ring_size);`
	`575`	`+nbuffers=Min(NBuffers /8,nbuffers);`
`576`	`576`
`577`	`577`	`/* Allocate the object and initialize all elements to zeroes */`
`578`	`578`	`strategy= (BufferAccessStrategy)`
`579`	`579`	`palloc0(offsetof(BufferAccessStrategyData,buffers)+`
`580`		`-ring_size*sizeof(Buffer));`
	`580`	`+nbuffers*sizeof(Buffer));`
`581`	`581`
`582`	`582`	`/* Set fields that don't start out zero */`
`583`	`583`	`strategy->btype=btype;`
`584`		`-strategy->ring_size=ring_size;`
	`584`	`+strategy->nbuffers=nbuffers;`
`585`	`585`
`586`	`586`	`returnstrategy;`
`587`	`587`	`}`
`@@ -615,7 +615,7 @@ GetBufferFromRing(BufferAccessStrategy strategy, uint32 *buf_state)`
`615`	`615`
`616`	`616`
`617`	`617`	`/* Advance to next ring slot */`
`618`		`-if (++strategy->current >=strategy->ring_size)`
	`618`	`+if (++strategy->current >=strategy->nbuffers)`
`619`	`619`	`strategy->current=0;`
`620`	`620`
`621`	`621`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8d928e3

File tree

1 file changed

1 file changed

`‎src/backend/storage/buffer/freelist.c`

0 commit comments