NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8d84dd0

committed

Fix crash in psql when attempting to reuse old connection

In a psql session, if the connection to the server is abruptly cut, thereferenced connection would become NULL as of CheckConnection(). Thiscould cause a hard crash with psql if attempting to connect by reusingthe past connection's data because of a null-pointer dereference witheither PQhost() or PQdb(). This issue is fixed by making sure that noreuse of the past connection is done if it does not exist.Issue has been introduced by6e5f8d4, so backpatch down to 12.Reported-by: Hugh WangAuthor: Michael PaquierReviewed-by: Álvaro Herrera, Tom LaneDiscussion:https://postgr.es/m/16330-b34835d83619e25d@postgresql.orgBackpatch-through: 12

1 parent2401d93 commit8d84dd0Copy full SHA for 8d84dd0

File tree

1 file changed

-0

lines changed

src/bin/psql
- command.c

1 file changed

-0

lines changed

`‎src/bin/psql/command.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2974,6 +2974,11 @@ do_connect(enum trivalue reuse_previous_specification,`
`2974`	`2974`	`reuse_previous= !has_connection_string;`
`2975`	`2975`	`break;`
`2976`	`2976`	`}`
	`2977`	`+`
	`2978`	`+/* If the old connection does not exist, there is nothing to reuse. */`
	`2979`	`+if (!o_conn)`
	`2980`	`+reuse_previous= false;`
	`2981`	`+`
`2977`	`2982`	`/* Silently ignore arguments subsequent to a connection string. */`
`2978`	`2983`	`if (has_connection_string)`
`2979`	`2984`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8d84dd0

File tree

1 file changed

1 file changed

`‎src/bin/psql/command.c`

0 commit comments