NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8d29d45

committed

Fix assert failure in expand_grouping_sets

linitial_node() fails in assert enabled builds if the given pointer isnot of the specified type. Here the type is IntList. The code thoughtit should be expecting List, but it was wrong.In the existing tests which run this code the initial list element isalways NIL. Since linitial_node() allows NULL, we didn't trigger anyassert failures in the existing regression tests.There is still some discussion as to whether we need a few more tests inthis area, but for now, since beta2 is looming, fix the bug first.Bug: #17067Discussion:https://postgr.es/m/17067-665d50fa321f79e0@postgresql.orgReported-by: Yaoguang Chen

1 parenta7bb0ce commit8d29d45Copy full SHA for 8d29d45

File tree

1 file changed

-1

lines changed

src/backend/parser
- parse_agg.c

1 file changed

-1

lines changed

`‎src/backend/parser/parse_agg.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1855,7 +1855,7 @@ expand_grouping_sets(List *groupingSets, bool groupDistinct, int limit)`
`1855`	`1855`	`list_sort(result,cmp_list_len_contents_asc);`
`1856`	`1856`
`1857`	`1857`	`/* Finally, remove duplicates */`
`1858`		`-prev=linitial_node(List,result);`
	`1858`	`+prev=linitial(result);`
`1859`	`1859`	`for_each_from(cell,result,1)`
`1860`	`1860`	`{`
`1861`	`1861`	`if (equal(lfirst(cell),prev))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8d29d45

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_agg.c`

0 commit comments