NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8d15e3e

committed

Don't forget to de-escape the password field in .pgpass.

This has been broken just about forever (or more specifically, commit7f4981f) and nobody noticed untilRichard Huxton reported it recently. Analysis and fix by RossReedstrom, although I didn't use his patch. This doesn't seemimportant enough to back-patch and is mildly backward incompatible, soI'm just doing this in master.

1 parentc31224e commit8d15e3eCopy full SHA for 8d15e3e

File tree

1 file changed

+13

-1

lines changed

src/interfaces/libpq
- fe-connect.c

1 file changed

+13

-1

lines changed

`‎src/interfaces/libpq/fe-connect.c`

Lines changed: 13 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4904,7 +4904,9 @@ PasswordFromFile(char hostname, char port, char dbname, char username)`
`4904`	`4904`	`while (!feof(fp)&& !ferror(fp))`
`4905`	`4905`	`{`
`4906`	`4906`	`char*t=buf,`
`4907`		`-*ret;`
	`4907`	`+*ret,`
	`4908`	`+*p1,`
	`4909`	`+*p2;`
`4908`	`4910`	`intlen;`
`4909`	`4911`
`4910`	`4912`	`if (fgets(buf,sizeof(buf),fp)==NULL)`
`@@ -4925,6 +4927,16 @@ PasswordFromFile(char hostname, char port, char dbname, char username)`
`4925`	`4927`	`continue;`
`4926`	`4928`	`ret=strdup(t);`
`4927`	`4929`	`fclose(fp);`
	`4930`	`+`
	`4931`	`+/* De-escape password. */`
	`4932`	`+for (p1=p2=ret;p1!=':'&&p1!='\0';++p1,++p2)`
	`4933`	`+{`
	`4934`	`+if (*p1=='\\'&&p1[1]!='\0')`
	`4935`	`+++p1;`
	`4936`	`+p2=p1;`
	`4937`	`+}`
	`4938`	`+*p2='\0';`
	`4939`	`+`
`4928`	`4940`	`returnret;`
`4929`	`4941`	`}`
`4930`	`4942`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8d15e3e

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-connect.c`

0 commit comments