NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8cb90b2

committed

Avoid minor leak in parallel pg_dump

During parallel pg_dump, a worker process closing the connection causeda minor memory leak (particularly minor as we are likely about to exitanyway). Instead, free the memory in this case prior to returning NULLto indicate connection closed.Spotting by the Coverity scanner.Back patch to 9.3 where this was introduced.

1 parentbe5d499 commit8cb90b2Copy full SHA for 8cb90b2

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- parallel.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/parallel.c‎`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1288,7 +1288,7 @@ readMessageFromPipe(int fd)`
`1288`	`1288`
`1289`	`1289`	`/* worker has closed the connection or another error happened */`
`1290`	`1290`	`if (ret <=0)`
`1291`		`-returnNULL;`
	`1291`	`+break;`
`1292`	`1292`
`1293`	`1293`	`Assert(ret==1);`
`1294`	`1294`
`@@ -1303,6 +1303,14 @@ readMessageFromPipe(int fd)`
`1303`	`1303`	`msg= (char*)realloc(msg,bufsize);`
`1304`	`1304`	`}`
`1305`	`1305`	`}`
	`1306`	`+`
	`1307`	`+/*`
	`1308`	`+ * Worker has closed the connection, make sure to clean up before return`
	`1309`	`+ * since we are not returning msg (but did allocate it).`
	`1310`	`+ */`
	`1311`	`+free(msg);`
	`1312`	`+`
	`1313`	`+returnNULL;`
`1306`	`1314`	`}`
`1307`	`1315`
`1308`	`1316`	`#ifdefWIN32`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8cb90b2

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/parallel.c‎`

0 commit comments