NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8c95168

committed

Teach datum_image_eq() about cstring datums.

Bring datum_image_eq() in line with datumIsEqual() by adding support forcomparing cstring datums.An upcoming patch that adds deduplication to the nbtree AM will usedatum_image_eq(). datum_image_eq() will need to work with all datatypesthat can be used as the storage type of a B-Tree index column, includingcstring. (cstring is used as the storage type for columns of type"name" as a space-saving optimization.)Discussion:https://postgr.es/m/CAH2-Wzn3Ee49Gmxb7V1VJ3-AC8fWn-Fr8pfWQebHe8rYRxt5OQ@mail.gmail.com

1 parent7a0574b commit8c95168Copy full SHA for 8c95168

File tree

1 file changed

+16

-3

lines changed

src/backend/utils/adt
- datum.c

1 file changed

+16

-3

lines changed

`‎src/backend/utils/adt/datum.c`

Lines changed: 16 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -263,6 +263,8 @@ datumIsEqual(Datum value1, Datum value2, bool typByVal, int typLen)`
`263`	`263`	`bool`
`264`	`264`	`datum_image_eq(Datumvalue1,Datumvalue2,booltypByVal,inttypLen)`
`265`	`265`	`{`
	`266`	`+Sizelen1,`
	`267`	`+len2;`
`266`	`268`	`boolresult= true;`
`267`	`269`
`268`	`270`	`if (typByVal)`
`@@ -277,9 +279,6 @@ datum_image_eq(Datum value1, Datum value2, bool typByVal, int typLen)`
`277`	`279`	`}`
`278`	`280`	`elseif (typLen==-1)`
`279`	`281`	`{`
`280`		`-Sizelen1,`
`281`		`-len2;`
`282`		`-`
`283`	`282`	`len1=toast_raw_datum_size(value1);`
`284`	`283`	`len2=toast_raw_datum_size(value2);`
`285`	`284`	`/* No need to de-toast if lengths don't match. */`
`@@ -304,6 +303,20 @@ datum_image_eq(Datum value1, Datum value2, bool typByVal, int typLen)`
`304`	`303`	`pfree(arg2val);`
`305`	`304`	`}`
`306`	`305`	`}`
	`306`	`+elseif (typLen==-2)`
	`307`	`+{`
	`308`	`+char*s1,`
	`309`	`+*s2;`
	`310`	`+`
	`311`	`+/* Compare cstring datums */`
	`312`	`+s1=DatumGetCString(value1);`
	`313`	`+s2=DatumGetCString(value2);`
	`314`	`+len1=strlen(s1)+1;`
	`315`	`+len2=strlen(s2)+1;`
	`316`	`+if (len1!=len2)`
	`317`	`+return false;`
	`318`	`+result= (memcmp(s1,s2,len1)==0);`
	`319`	`+}`
`307`	`320`	`else`
`308`	`321`	`elog(ERROR,"unexpected typLen: %d",typLen);`
`309`	`322`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8c95168

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/datum.c`

0 commit comments