Commit8c71467

Etsuro Fujita

committed

Correct error message for row-level triggers with transition tables on partitioned tables.

"Triggers on partitioned tables cannot have transition tables." isincorrect as we allow statement-level triggers on partitioned tables tohave transition tables.This has been wrong since commit86f5759; back-patch to v11 where thatcommit came in.Reviewed by Tom Lane.Discussion:https://postgr.es/m/CAPmGK17gk4vXLzz2iG%2BG4LWRWCoVyam70nZ3OuGm1hMJwDrhcg%40mail.gmail.com

1 parent3e77b2e commit8c71467Copy full SHA for 8c71467

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,7 @@ CreateTriggerFiringOn(CreateTrigStmt stmt, const char queryString,`
`264`	`264`	`(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
`265`	`265`	`errmsg("\"%s\" is a partitioned table",`
`266`	`266`	`RelationGetRelationName(rel)),`
`267`		`-errdetail("Triggers on partitionedtablescannot have transition tables.")));`
	`267`	`+errdetail("ROW triggers with transitiontablesare not supported on partitioned tables.")));`
`268`	`268`	`}`
`269`	`269`	`}`
`270`	`270`	`elseif (rel->rd_rel->relkind==RELKIND_VIEW)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2046,7 +2046,7 @@ create trigger failed after update on parted_trig`
`2046`	`2046`	`referencing old table as old_table`
`2047`	`2047`	`for each row execute procedure trigger_nothing();`
`2048`	`2048`	`ERROR: "parted_trig" is a partitioned table`
`2049`		`-DETAIL:Triggers on partitionedtablescannot have transition tables.`
	`2049`	`+DETAIL:ROW triggers with transitiontablesare not supported on partitioned tables.`
`2050`	`2050`	`drop table parted_trig;`
`2051`	`2051`	`--`
`2052`	`2052`	`-- Verify trigger creation for partitioned tables, and drop behavior`

Comments

(0)