forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit8c1cd72
committed
Remove recovery test 011_crash_recovery.pl
This test has been added as of857ee8e that has introduced the SQLfunction txid_status(), with the purpose of checking that a transactionID still in-progress during a crash is correctly marked as aborted afterrecovery finishes.This test is unstable, and some configuration scenarios may that easierto reproduce (wal_level=minimal, wal_compression=on) because the WALholding the information about the in-progress transaction ID may nothave made it to disk yet, hence a post-crash recovery may cause the sameXID to be reused, triggering a test failure.We have discussed a few approaches, like making this function force aWAL flush to make it reliable across crashes, but we don't want to pay aperformance penalty in some scenarios, as well. The test could havebeen tweaked to enforce a checkpoint but that actually breaks thepromise of the test to rely on a stable result of txid_status() aftera crash.This issue has been reported a few times across the past years, with anoriginal report from Kyotaro Horiguchi. The buildfarm machines tanager,hachi and gokiburi enable wal_compression, and fail on this testperiodically.Discussion:https://postgr.es/m/3163112.1674762209@sss.pgh.pa.usDiscussion:https://postgr.es/m/20210305.115011.558061052471425531.horikyota.ntt@gmail.comBackpatch-through: 111 parent54e72b6 commit8c1cd72
2 files changed
+0
-64
lines changedLines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
Lines changed: 0 additions & 63 deletions
This file was deleted.
0 commit comments
Comments
(0)