Commit8bf5af2

committed

Fix small memory leak in psql's \bind command

psql_scan_slash_option() returns a malloc()'d result through aPQExpBuffer, and exec_command_bind() was doing an extra allocation ofthis option for no effect.Introduced in5b66de3.Author: Kyotaro HoriguchiReviewed-by: Corey HuinkerDiscussion:https://postgr.es/m/20230221.115555.89096938631423206.horikyota.ntt@gmail.com

1 parent1a943d0 commit8bf5af2Copy full SHA for 8bf5af2

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -480,7 +480,7 @@ exec_command_bind(PsqlScanState scan_state, bool active_branch)`
`480`	`480`	`nalloc=nalloc ?nalloc*2 :1;`
`481`	`481`	`pset.bind_params=pg_realloc_array(pset.bind_params,char*,nalloc);`
`482`	`482`	`}`
`483`		`-pset.bind_params[nparams-1]=pg_strdup(opt);`
	`483`	`+pset.bind_params[nparams-1]=opt;`
`484`	`484`	`}`
`485`	`485`
`486`	`486`	`pset.bind_nparams=nparams;`

Comments

(0)