NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8bdd6f5

committed

Use a more portable way to get the version string in PostgresNode

Older versions of perl on Windows don't like the list form of pipe open,and perlcritic doesn't like the string form of open, so we avoid bothwith a simpler formulation using qx{}.Per complaint from Amit Kapila.

1 parent413c1ef commit8bdd6f5Copy full SHA for 8bdd6f5

File tree

1 file changed

-4

lines changed

src/test/perl
- PostgresNode.pm

1 file changed

-4

lines changed

`‎src/test/perl/PostgresNode.pm`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1248,10 +1248,8 @@ sub _set_pg_version`
`1248`	`1248`	`local%ENV =$self->_get_env();`
`1249`	`1249`
`1250`	`1250`	`# We only want the version field`
`1251`		`-openmy$fh,"-\|",$pg_config,"--version"`
`1252`		`-or BAIL_OUT("$pg_config failed:$!");`
`1253`		`-my$version_line = <$fh>;`
`1254`		`-close$fhordie;`
	`1251`	`+my$version_line =qx{$pg_config --version};`
	`1252`	`+BAIL_OUT("$pg_config failed:$!")if$?;`
`1255`	`1253`
`1256`	`1254`	`$self->{_pg_version} = PostgresVersion->new($version_line);`
`1257`	`1255`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8bdd6f5

File tree

1 file changed

1 file changed

`‎src/test/perl/PostgresNode.pm`

0 commit comments