NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8bc7449

committed

Fix use-after-release mistake in currtid() and currtid2() for views

This issue has been present since the introduction of this code as ofa3519a2 from 2002, and has been found by buildfarm member prion thatuses RELCACHE_FORCE_RELEASE via the tests introduced recently ine786be5.Discussion:https://postgr.es/m/20200601022055.GB4121@paquier.xyzBackpatch-through: 9.5

1 parentf4f4d64 commit8bc7449Copy full SHA for 8bc7449

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- tid.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/tid.c`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -309,8 +309,13 @@ currtid_for_view(Relation viewrel, ItemPointer tid)`
`309`	`309`	`rte=rt_fetch(var->varno,query->rtable);`
`310`	`310`	`if (rte)`
`311`	`311`	`{`
	`312`	`+Datumresult;`
	`313`	`+`
	`314`	`+result=DirectFunctionCall2(currtid_byreloid,`
	`315`	`+ObjectIdGetDatum(rte->relid),`
	`316`	`+PointerGetDatum(tid));`
`312`	`317`	`heap_close(viewrel,AccessShareLock);`
`313`		`-returnDirectFunctionCall2(currtid_byreloid,ObjectIdGetDatum(rte->relid),PointerGetDatum(tid));`
	`318`	`+returnresult;`
`314`	`319`	`}`
`315`	`320`	`}`
`316`	`321`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8bc7449

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/tid.c`

0 commit comments