NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8bbbcb9

committed

Fix bug in the new GIN incomplete-split code.

Inserting a downlink to an internal page clears the incomplete-split flagof the child's left sibling, so the left sibling's LSN also needs to beupdated and it needs to be marked dirty. The codepath for an insertion gotthis right, but the case where the internal node is split because ofinserting the new downlink missed that.

1 parent6eff0ac commit8bbbcb9Copy full SHA for 8bbbcb9

File tree

1 file changed

-0

lines changed

src/backend/access/gin
- ginbtree.c

1 file changed

-0

lines changed

`‎src/backend/access/gin/ginbtree.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -543,6 +543,8 @@ ginPlaceToPage(GinBtree btree, GinBtreeStack *stack,`
`543`	`543`
`544`	`544`	`MarkBufferDirty(rbuffer);`
`545`	`545`	`MarkBufferDirty(stack->buffer);`
	`546`	`+if (BufferIsValid(childbuf))`
	`547`	`+MarkBufferDirty(childbuf);`
`546`	`548`
`547`	`549`	`/*`
`548`	`550`	`* Restore the temporary copies over the real buffers. But don't free`
`@@ -571,6 +573,8 @@ ginPlaceToPage(GinBtree btree, GinBtreeStack *stack,`
`571`	`573`	`PageSetLSN(BufferGetPage(rbuffer),recptr);`
`572`	`574`	`if (stack->parent==NULL)`
`573`	`575`	`PageSetLSN(BufferGetPage(lbuffer),recptr);`
	`576`	`+if (BufferIsValid(childbuf))`
	`577`	`+PageSetLSN(childpage,recptr);`
`574`	`578`	`}`
`575`	`579`	`END_CRIT_SECTION();`
`576`	`580`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8bbbcb9

File tree

1 file changed

1 file changed

`‎src/backend/access/gin/ginbtree.c`

0 commit comments