NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8b90174

committed

Fix bogus logic for skipping unnecessary partcollation dependencies.

The idea here is to not call recordDependencyOn for the default collation,since we know that's pinned. But what the code actually did was to recordthe partition key's dependency on the opclass twice, instead.Evidently introduced by sloppy coding in commit2186b60. Back-patchto v10 where that came in.

1 parenta0696d2 commit8b90174Copy full SHA for 8b90174

File tree

1 file changed

-3

lines changed

src/backend/catalog
- heap.c

1 file changed

-3

lines changed

`‎src/backend/catalog/heap.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3145,7 +3145,7 @@ StorePartitionKey(Relation rel,`
`3145`	`3145`
`3146`	`3146`	`/* Mark this relation as dependent on a few things as follows */`
`3147`	`3147`	`myself.classId=RelationRelationId;`
`3148`		`-myself.objectId=RelationGetRelid(rel);;`
	`3148`	`+myself.objectId=RelationGetRelid(rel);`
`3149`	`3149`	`myself.objectSubId=0;`
`3150`	`3150`
`3151`	`3151`	`/* Operator class and collation per key column */`
`@@ -3164,9 +3164,9 @@ StorePartitionKey(Relation rel,`
`3164`	`3164`	`referenced.classId=CollationRelationId;`
`3165`	`3165`	`referenced.objectId=partcollation[i];`
`3166`	`3166`	`referenced.objectSubId=0;`
`3167`		`-}`
`3168`	`3167`
`3169`		`-recordDependencyOn(&myself,&referenced,DEPENDENCY_NORMAL);`
	`3168`	`+recordDependencyOn(&myself,&referenced,DEPENDENCY_NORMAL);`
	`3169`	`+}`
`3170`	`3170`	`}`
`3171`	`3171`
`3172`	`3172`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8b90174

File tree

1 file changed

1 file changed

`‎src/backend/catalog/heap.c`

0 commit comments