Commit8b5b3e0

committed

pg_dump barfs on negative values for index column numbers --- like, say,

an index on a table's OID column. Mea maxima culpa ... but how'd we getthrough beta with no one noticing this?

1 parent4763cdd commit8b5b3e0Copy full SHA for 8b5b3e0

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/bin/pg_dump/common.c,v 1.41 2000/04/12 17:16:14 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/bin/pg_dump/common.c,v 1.42 2000/05/19 23:00:00 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`* Modifications - 6/12/96 - dave@bensoft.com - version 1.13.dhb.2`
`14`	`14`	`*`
`@@ -190,7 +190,7 @@ parseNumericArray(const char str, char *array, int arraysize)`
`190`	`190`	`}`
`191`	`191`	`else`
`192`	`192`	`{`
`193`		`-if (!isdigit(s)\|\|j >=sizeof(temp)-1)`
	`193`	`+if (!(isdigit(s)\|\|s=='-')\|\|j >=sizeof(temp)-1)`
`194`	`194`	`{`
`195`	`195`	`fprintf(stderr,"parseNumericArray: bogus number\n");`
`196`	`196`	`exit(2);`

Comments

(0)