Commit8b5262f

Amit Kapila

committed

Improve comments referring snapshot's subxip array.

It was referred to as subxact array in a few places and subxip array inothers. By changing it to subxip array, we make it consistent with similarreferences to xip array.Author: Japin LiReviewd by: Julien Rouhaud, Richard GuoDiscussion:https://postgr.es/m/MEYP282MB1669DCE7AC193A947CED2A95B6009@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM

1 parente848be6 commit8b5262fCopy full SHA for 8b5262f

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2409,7 +2409,7 @@ GetSnapshotData(Snapshot snapshot)`
`2409`	`2409`	`* We could try to store xids into xip[] first and then into subxip[]`
`2410`	`2410`	`* if there are too many xids. That only works if the snapshot doesn't`
`2411`	`2411`	`* overflow because we do not search subxip[] in that case. A simpler`
`2412`		`- * way is to just store all xids in thesubxact array because this is`
	`2412`	`+ * way is to just store all xids in thesubxip array because this is`
`2413`	`2413`	`* by far the bigger array. We just leave the xip array empty.`
`2414`	`2414`	`*`
`2415`	`2415`	`* Either way we need to change the way XidInMVCCSnapshot() works`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2345,7 +2345,7 @@ XidInMVCCSnapshot(TransactionId xid, Snapshot snapshot)`
`2345`	`2345`	`else`
`2346`	`2346`	`{`
`2347`	`2347`	`/*`
`2348`		`- * In recovery we store all xids in thesubxact array because it is by`
	`2348`	`+ * In recovery we store all xids in thesubxip array because it is by`
`2349`	`2349`	`* far the bigger array, and we mostly don't know which xids are`
`2350`	`2350`	`* top-level and which are subxacts. The xip array is empty.`
`2351`	`2351`	`*`

Comments

(0)