NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8b49392

committed

Tweak regex to avoid a bug in Perl 5.16.3.

For some reason, 5.16.3 (and perhaps slightly earlier/later versions)go into an infinite loop with the version-replacement regex installedby commitfc0d0ce. We can work around that by using an explicit"\n" instead of the line-start metacharacter "^".Reported-by: Sami Imseih <samimseih@gmail.com>Discussion:https://postgr.es/m/CAA5RZ0u9dV3CdKqkqdusA_RdvBkwWe0c0rxcFWj++VYoutFYSw@mail.gmail.com

1 parent7717f63 commit8b49392Copy full SHA for 8b49392

File tree

1 file changed

-2

lines changed

src/test/perl/PostgreSQL/Test
- AdjustUpgrade.pm

1 file changed

-2

lines changed

`‎src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,7 @@ sub adjust_old_dumpfile`
`296`	`296`
`297`	`297`	`# Same with version argument to pg_restore_relation_stats() or`
`298`	`298`	`# pg_restore_attribute_stats().`
`299`		`-$dump =~s {(^\s+'version',) '\d+'::integer,$}`
	`299`	`+$dump =~s {\n(\s+'version',) '\d+'::integer,$}`
`300`	`300`	`{$1'000000'::integer,}mg;`
`301`	`301`
`302`	`302`	`if ($old_version < 16)`
`@@ -645,7 +645,7 @@ sub adjust_new_dumpfile`
`645`	`645`
`646`	`646`	`# Same with version argument to pg_restore_relation_stats() or`
`647`	`647`	`# pg_restore_attribute_stats().`
`648`		`-$dump =~s {(^\s+'version',) '\d+'::integer,$}`
	`648`	`+$dump =~s {\n(\s+'version',) '\d+'::integer,$}`
`649`	`649`	`{$1'000000'::integer,}mg;`
`650`	`650`
`651`	`651`	`# pre-v16 dumps do not know about XMLSERIALIZE(NO INDENT).`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8b49392

File tree

1 file changed

1 file changed

`‎src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm`

0 commit comments