forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit8afff7d
committed
Improve reporting of pg_upgrade log files on test failure
On failure, the pg_upgrade log files are automatically appended to thetest log file, but the information reported was inconsistent.A header, with the log file name, was reported with note(), while thelog contents and a footer used print(), making it harder to diagnosefailures when these are split into console output and test log filebecause the pg_upgrade log file path in the header may not be includedin the test log file.The output is now consolidated so as the header uses print() rather thannote(). An extra note() is added to inform that the contents of apg_upgrade log file are appended to the test log file.The diffs from the regression test suite and dump files all use print()to show their contents on failure.Author: Joel JacobsonReviewed-by: Daniel GustafssonDiscussion:https://postgr.es/m/49f7e64a-b9be-4a90-a9fe-210a7740405e@app.fastmail.comBackpatch-through: 151 parent4bd9de3 commit8afff7d
1 file changed
+6
-1
lines changedLines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
475 | 475 | | |
476 | 476 | | |
477 | 477 | | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
478 | 482 | | |
479 | 483 | | |
480 | | - | |
| 484 | + | |
| 485 | + | |
481 | 486 | | |
482 | 487 | | |
483 | 488 | | |
| |||
0 commit comments
Comments
(0)