Commit8ad6c5d

committed

Add HINT for restartpoint race with KeepFileRestoredFromArchive().

The five commits ending atcc2c7d6closed this race condition for v15+. For v14 through v10, add a HINT todiscourage studying the cosmetic problem.Reviewed by Kyotaro Horiguchi and David Steele.Discussion:https://postgr.es/m/20220731061747.GA3692882@rfd.leadboat.com

1 parent6d9481c commit8ad6c5dCopy full SHA for 8ad6c5d

File tree

+12

-3

lines changed

+12

-3

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3481,7 +3481,10 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock)`
`3481`	`3481`	`if (fd<0)`
`3482`	`3482`	`ereport(ERROR,`
`3483`	`3483`	`(errcode_for_file_access(),`
`3484`		`-errmsg("could not open file \"%s\": %m",path)));`
	`3484`	`+errmsg("could not open file \"%s\": %m",path),`
	`3485`	`+ (AmCheckpointerProcess() ?`
	`3486`	`+errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :`
	`3487`	`+0)));`
`3485`	`3488`
`3486`	`3489`	`elog(DEBUG2,"done creating and filling new WAL file");`
`3487`	`3490`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -834,7 +834,10 @@ durable_rename_excl(const char oldfile, const char newfile, int elevel)`
`834`	`834`	`ereport(elevel,`
`835`	`835`	`(errcode_for_file_access(),`
`836`	`836`	`errmsg("could not link file \"%s\" to \"%s\": %m",`
`837`		`-oldfile,newfile)));`
	`837`	`+oldfile,newfile),`
	`838`	`+ (AmCheckpointerProcess() ?`
	`839`	`+errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :`
	`840`	`+0)));`
`838`	`841`	`return-1;`
`839`	`842`	`}`
`840`	`843`	`unlink(oldfile);`
`@@ -844,7 +847,10 @@ durable_rename_excl(const char oldfile, const char newfile, int elevel)`
`844`	`847`	`ereport(elevel,`
`845`	`848`	`(errcode_for_file_access(),`
`846`	`849`	`errmsg("could not rename file \"%s\" to \"%s\": %m",`
`847`		`-oldfile,newfile)));`
	`850`	`+oldfile,newfile),`
	`851`	`+ (AmCheckpointerProcess() ?`
	`852`	`+errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :`
	`853`	`+0)));`
`848`	`854`	`return-1;`
`849`	`855`	`}`
`850`	`856`	`#endif`

Comments

(0)