NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8ad6a0c

committed

Plug memory leak in index_get_partition

The list of indexes was being leaked when asked for an index thatdoesn't have an index partition in the table partition. Not a commoncase admittedly --and in most cases where it occurs, caller throws anerror anyway-- but worth fixing for cleanliness and in case anythird-party code is calling this function.While at it, remove use of lfirst_oid() to obtain a value we alreadyhave.Author: Justin Pryzby <pryzby@telsasoft.com>Reviewed-by: Michael Paquier <michael@paquier.xyz>Discussion:https://postgr.es/m/20201105203606.GF22691@telsasoft.com

1 parent8149e9f commit8ad6a0cCopy full SHA for 8ad6a0c

File tree

1 file changed

-1

lines changed

src/backend/catalog
- partition.c

1 file changed

-1

lines changed

`‎src/backend/catalog/partition.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -171,13 +171,14 @@ index_get_partition(Relation partition, Oid indexId)`
`171`	`171`	`ReleaseSysCache(tup);`
`172`	`172`	`if (!ispartition)`
`173`	`173`	`continue;`
`174`		`-if (get_partition_parent(lfirst_oid(l))==indexId)`
	`174`	`+if (get_partition_parent(partIdx)==indexId)`
`175`	`175`	`{`
`176`	`176`	`list_free(idxlist);`
`177`	`177`	`returnpartIdx;`
`178`	`178`	`}`
`179`	`179`	`}`
`180`	`180`
	`181`	`+list_free(idxlist);`
`181`	`182`	`returnInvalidOid;`
`182`	`183`	`}`
`183`	`184`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8ad6a0c

File tree

1 file changed

1 file changed

`‎src/backend/catalog/partition.c`

0 commit comments