forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit8993d3a
committed
Ensure static libraries have correct mod time even if ranlib messes it up.
In at least Apple's version of ranlib, the output file is updated to havea mod time equal to the max of the timestamps of its components, and thatdata only has seconds precision. On a filesystem with sub-second filetimestamp precision --- say, APFS --- this can result in the finishedstatic library appearing older than its input files, which causes uselessrebuilds and possible outright failures in parallel makes.We've only seen this reported in the field from people using Apple'sranlib with a non-Apple make, because Apple's make doesn't know aboutsub-second timestamps either so it doesn't decide rebuilds are needed.But Apple's ranlib presumably shares code with at least some BSDen,so it's not that unlikely that the same problem could arise elsewhere.To fix, just "touch" the output file after ranlib finishes.We seem to need this in only one place. There are other calls ofranlib in our makefiles, but they are working on intermediate fileswhose timestamps are not actually important, or else on an installedstatic library for which sub-second timestamp precision is unlikelyto matter either. (Also, so far as I can tell, Apple's ranlib doesn'tmess up the file timestamp in the latter usage anyhow.)In passing, change "ranlib" to "$(RANLIB)" in one place that wasbypassing the make macro for no good reason.Per bug #15525 from Jack Kelly (via Alyssa Ross).Back-patch to all supported branches.Discussion:https://postgr.es/m/15525-a30da084f17a1faa@postgresql.org1 parent8340eba commit8993d3a
1 file changed
+7
-1
lines changedLines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
303 | 308 | | |
304 | 309 | | |
305 | 310 | | |
306 | 311 | | |
307 | 312 | | |
| 313 | + | |
308 | 314 | | |
309 | 315 | | |
310 | 316 | | |
| |||
472 | 478 | | |
473 | 479 | | |
474 | 480 | | |
475 | | - | |
| 481 | + | |
476 | 482 | | |
477 | 483 | | |
478 | 484 | | |
| |||
0 commit comments
Comments
(0)