NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit88a4cb3

committed

Fix GET DIAGNOSTICS for case of assignment to function's first variable.

An incorrect and entirely unnecessary "safety check" in exec_stmt_getdiag()caused the code to treat an assignment to a variable with dno zero as ano-op. Unfortunately, that's a perfectly valid dno. This has been brokensince GET DIAGNOSTICS was invented. It's not terribly surprising that thebug went unnoticed for so long, since in most cases you probably wouldn'tuse the function's first-created variable (normally its first parameter)as a GET DIAGNOSTICS target. Nonetheless, it's broken. Per bug #6551from Adam Buraczewski.

1 parente9ce658 commit88a4cb3Copy full SHA for 88a4cb3

File tree

1 file changed

-9

lines changed

src/pl/plpgsql/src
- pl_exec.c

1 file changed

-9

lines changed

`‎src/pl/plpgsql/src/pl_exec.c`

Lines changed: 1 addition & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -1447,17 +1447,9 @@ exec_stmt_getdiag(PLpgSQL_execstate estate, PLpgSQL_stmt_getdiag stmt)`
`1447`	`1447`	`foreach(lc,stmt->diag_items)`
`1448`	`1448`	`{`
`1449`	`1449`	`PLpgSQL_diag_itemdiag_item= (PLpgSQL_diag_item)lfirst(lc);`
`1450`		`-PLpgSQL_datum*var;`
	`1450`	`+PLpgSQL_datum*var=estate->datums[diag_item->target];`
`1451`	`1451`	`boolisnull= false;`
`1452`	`1452`
`1453`		`-if (diag_item->target <=0)`
`1454`		`-continue;`
`1455`		`-`
`1456`		`-var=estate->datums[diag_item->target];`
`1457`		`-`
`1458`		`-if (var==NULL)`
`1459`		`-continue;`
`1460`		`-`
`1461`	`1453`	`switch (diag_item->kind)`
`1462`	`1454`	`{`
`1463`	`1455`	`casePLPGSQL_GETDIAG_ROW_COUNT:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit88a4cb3

File tree

1 file changed

1 file changed

`‎src/pl/plpgsql/src/pl_exec.c`

0 commit comments