NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8870e29

committed

Use snprintf not sprintf in pg_waldump's timestamptz_to_str.

This could only cause an issue if strftime returned a ridiculouslylong timezone name, which seems unlikely; and it wouldn't qualifyas a security problem even then, since pg_waldump (nee pg_xlogdump)is a debug tool not part of the server. But gcc 8 has started issuingwarnings about it, so let's use snprintf and be safe.Backpatch to 9.3 where this code was added.Discussion:https://postgr.es/m/21789.1529170195@sss.pgh.pa.us

1 parente951f66 commit8870e29Copy full SHA for 8870e29

File tree

1 file changed

-2

lines changed

src/bin/pg_xlogdump
- compat.c

1 file changed

-2

lines changed

`‎src/bin/pg_xlogdump/compat.c‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,11 @@ timestamptz_to_str(TimestampTz dt)`
`64`	`64`	`strftime(zone,sizeof(zone),"%Z",ltime);`
`65`	`65`
`66`	`66`	`#ifdefHAVE_INT64_TIMESTAMP`
`67`		`-sprintf(buf,"%s.%06d %s",ts, (int) (dt %USECS_PER_SEC),zone);`
	`67`	`+snprintf(buf,sizeof(buf),`
	`68`	`+"%s.%06d %s",ts, (int) (dt %USECS_PER_SEC),zone);`
`68`	`69`	`#else`
`69`		`-sprintf(buf,"%s.%.6f %s",ts,fabs(dt-floor(dt)),zone);`
	`70`	`+snprintf(buf,sizeof(buf),`
	`71`	`+"%s.%.6f %s",ts,fabs(dt-floor(dt)),zone);`
`70`	`72`	`#endif`
`71`	`73`
`72`	`74`	`returnbuf;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8870e29

File tree

1 file changed

1 file changed

`‎src/bin/pg_xlogdump/compat.c‎`

0 commit comments