Commit884a608

committed

Fix parallel index scan hang with deleted or half-dead pages.

The previous coding forgot to release the scan before seizingit again, leading to a lockup.Report by Patrick Hemmer. Diagnosis by Thomas Munro. Patch byAmit Kapila.Discussion:http://postgr.es/m/CAEepm=2xZUcOGP9V0O_G0=2P2wwXwPrkF=upWTCJSisUxMnuSg@mail.gmail.com

1 parent1d6fb35 commit884a608Copy full SHA for 884a608

File tree

+10

-0

lines changed

+10

-0

lines changed

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1486,6 +1486,11 @@ _bt_readnextpage(IndexScanDesc scan, BlockNumber blkno, ScanDirection dir)`
`1486`	`1486`	`if (_bt_readpage(scan,dir,P_FIRSTDATAKEY(opaque)))`
`1487`	`1487`	`break;`
`1488`	`1488`	`}`
	`1489`	`+elseif (scan->parallel_scan!=NULL)`
	`1490`	`+{`
	`1491`	`+/* allow next page be processed by parallel worker */`
	`1492`	`+_bt_parallel_release(scan,opaque->btpo_next);`
	`1493`	`+}`
`1489`	`1494`
`1490`	`1495`	`/* nope, keep going */`
`1491`	`1496`	`if (scan->parallel_scan!=NULL)`
`@@ -1581,6 +1586,11 @@ _bt_readnextpage(IndexScanDesc scan, BlockNumber blkno, ScanDirection dir)`
`1581`	`1586`	`if (_bt_readpage(scan,dir,PageGetMaxOffsetNumber(page)))`
`1582`	`1587`	`break;`
`1583`	`1588`	`}`
	`1589`	`+elseif (scan->parallel_scan!=NULL)`
	`1590`	`+{`
	`1591`	`+/* allow next page be processed by parallel worker */`
	`1592`	`+_bt_parallel_release(scan,BufferGetBlockNumber(so->currPos.buf));`
	`1593`	`+}`
`1584`	`1594`
`1585`	`1595`	`/*`
`1586`	`1596`	`* For parallel scans, get the last page scanned as it is quite`

Comments

(0)