NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit87b6c3c

Richard Guo

committed

Fix order of parameters in a cost_sort call

In label_sort_with_costsize, the cost_sort function is called with theparameters 'input_disabled_nodes' and 'input_cost' in the wrong order.This does not cause any plan diffs in the regression tests, becauselabel_sort_with_costsize is only used to label the Sort node nicelyfor EXPLAIN, and cost numbers are not displayed in regression tests.Oversight ine222534. Fixed by passing arguments in the rightorder.Per report from Alexander Lakhin running UBSan.Author: Alexander LakhinDiscussion:https://postgr.es/m/a9b7231d-68bc-f117-a07c-96688f3e6aef@gmail.com

1 parentfc415ed commit87b6c3cCopy full SHA for 87b6c3c

File tree

1 file changed

-1

lines changed

src/backend/optimizer/plan
- createplan.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/plan/createplan.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5454,8 +5454,8 @@ label_sort_with_costsize(PlannerInfo root, Sort plan, double limit_tuples)`
`5454`	`5454`	`Assert(IsA(plan,Sort));`
`5455`	`5455`
`5456`	`5456`	`cost_sort(&sort_path,root,NIL,`
`5457`		`-lefttree->total_cost,`
`5458`	`5457`	`plan->plan.disabled_nodes,`
	`5458`	`+lefttree->total_cost,`
`5459`	`5459`	`lefttree->plan_rows,`
`5460`	`5460`	`lefttree->plan_width,`
`5461`	`5461`	`0.0,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit87b6c3c

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/createplan.c`

0 commit comments