Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit87591db

Browse files
committed
Log the correct ending timestamp in recovery_target_xid mode.
When ending recovery based on recovery_target_xid matching withrecovery_target_inclusive = off, we printed an incorrect timestamp(always 2000-01-01) in the "recovery stopping before ... transaction"log message. This is a consequence of sloppy refactoring inc945af8: the code to fetch recordXtime out of the commit/abortrecord used to be executed unconditionally, but it was changedto get called only in the RECOVERY_TARGET_TIME case. We need onlyflip the order of operations to restore the intended behavior.Per report from Torsten Förtsch. Back-patch to all supportedbranches.Discussion:https://postgr.es/m/CAKkG4_kUevPqbmyOfLajx7opAQk6Cvwkvx0HRcFjSPfRPTXanA@mail.gmail.com
1 parent162a482 commit87591db

File tree

1 file changed

+7
-2
lines changed
  • src/backend/access/transam

1 file changed

+7
-2
lines changed

‎src/backend/access/transam/xlog.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5782,8 +5782,13 @@ recoveryStopsBefore(XLogReaderState *record)
57825782
stopsHere= (recordXid==recoveryTargetXid);
57835783
}
57845784

5785-
if (recoveryTarget==RECOVERY_TARGET_TIME&&
5786-
getRecordTimestamp(record,&recordXtime))
5785+
/*
5786+
* Note: we must fetch recordXtime regardless of recoveryTarget setting.
5787+
* We don't expect getRecordTimestamp ever to fail, since we already know
5788+
* this is a commit or abort record; but test its result anyway.
5789+
*/
5790+
if (getRecordTimestamp(record,&recordXtime)&&
5791+
recoveryTarget==RECOVERY_TARGET_TIME)
57875792
{
57885793
/*
57895794
* There can be many transactions that share the same commit time, so

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp