NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit872c149

committed

Previous fix for "x FULL JOIN y ON true" failed to handle the case

where there was also a WHERE-clause restriction that applied to thejoin. The check on restrictlist == NIL is really unnecessary anyway,because select_mergejoin_clauses already checked for and complainedabout any unmergejoinable join clauses. So just take it out.

1 parentbc6444d commit872c149Copy full SHA for 872c149

File tree

1 file changed

-7

lines changed

src/backend/optimizer/path
- joinpath.c

1 file changed

-7

lines changed

`‎src/backend/optimizer/path/joinpath.c`

Lines changed: 2 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/optimizer/path/joinpath.c,v 1.93 2005/04/19 22:35:15 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/optimizer/path/joinpath.c,v 1.94 2005/05/24 18:02:31 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -499,15 +499,10 @@ match_unsorted_outer(Query *root,`
`499`	`499`	`* nestloop path, but since mergejoin is our only join type that`
`500`	`500`	`* supports FULL JOIN, it's necessary to generate a clauseless`
`501`	`501`	`* mergejoin path instead.`
`502`		`- *`
`503`		`- * Unfortunately this can't easily be extended to handle the case`
`504`		`- * where there are joinclauses but none of them use mergejoinable`
`505`		`- * operators; nodeMergejoin.c can only do a full join correctly if`
`506`		`- * all the joinclauses are mergeclauses.`
`507`	`502`	`*/`
`508`	`503`	`if (mergeclauses==NIL)`
`509`	`504`	`{`
`510`		`-if (jointype==JOIN_FULL&&restrictlist==NIL)`
	`505`	`+if (jointype==JOIN_FULL)`
`511`	`506`	`/* okay to try for mergejoin */ ;`
`512`	`507`	`else`
`513`	`508`	`continue;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit872c149

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/joinpath.c`

0 commit comments